Feat/crypto registry aes gcm siv#759
Conversation
bhess
left a comment
There was a problem hiding this comment.
Thank you, @Mehrn0ush, for adding AES-GCM-SIV, this looks good to me.
Please check my comment regarding the pattern.
I also noticed some changes duplicated from your other PRs (XChaCha20, TUAK, and bcrypt). You might want to remove those from this PR to ensure a clean merge.
There was a problem hiding this comment.
Pull request overview
This PR adds AES-GCM-SIV support to the Cryptography Registry as requested in issue #758. However, it also includes several unrelated changes that were not mentioned in the PR description.
Changes:
- Adds AES-GCM-SIV (RFC 8452) as an AEAD variant to the AES family
- Adds XChaCha20-Poly1305 to ChaCha20 family variants (not mentioned in PR description)
- Removes BLAKE2b-HMAC variant (not mentioned in PR description)
- Fixes spelling errors in TUAK patterns (TUAC -> TUAK)
- Fixes typo in bcrypt pattern (closing parenthesis -> closing brace)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
stevespringett
left a comment
There was a problem hiding this comment.
Please update the pattern based on the suggestion from @bhess
stevespringett
left a comment
There was a problem hiding this comment.
Thanks for the PR. Could you resolve the issue that @bhess mentioned? Once corrected, we'll merge this in. Thanks again
c36a357 to
52a3a59
Compare
Signed-off-by: Mehrn0ush <mehrnoush.vaseghi@gmail.com>
52a3a59 to
f613597
Compare
As discussed in ticket #758, this PR adds AES-GCM-SIV as an AEAD variant to the Cryptography Registry.
Fixes #758
Details
aevariant under the existing AES familyScope
schema/cryptography-defs.json)