Skip to content

Comments

Feat/crypto registry aes gcm siv#759

Merged
stevespringett merged 1 commit intoCycloneDX:masterfrom
Mehrn0ush:feat/crypto-registry-aes-gcm-siv
Feb 19, 2026
Merged

Feat/crypto registry aes gcm siv#759
stevespringett merged 1 commit intoCycloneDX:masterfrom
Mehrn0ush:feat/crypto-registry-aes-gcm-siv

Conversation

@Mehrn0ush
Copy link
Contributor

As discussed in ticket #758, this PR adds AES-GCM-SIV as an AEAD variant to the Cryptography Registry.

Fixes #758

Details

  • Adds standardized AES-GCM-SIV (RFC 8452) as an ae variant under the existing AES family

Scope

  • Registry data only (schema/cryptography-defs.json)
  • No schema or specification behavior changes

@Mehrn0ush Mehrn0ush requested a review from a team as a code owner January 1, 2026 15:03
@stevespringett stevespringett added the cap: cryptography Capability: Cryptography (CBOM) label Jan 2, 2026
Copy link
Contributor

@bhess bhess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Mehrn0ush, for adding AES-GCM-SIV, this looks good to me.

Please check my comment regarding the pattern.
I also noticed some changes duplicated from your other PRs (XChaCha20, TUAK, and bcrypt). You might want to remove those from this PR to ensure a clean merge.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds AES-GCM-SIV support to the Cryptography Registry as requested in issue #758. However, it also includes several unrelated changes that were not mentioned in the PR description.

Changes:

  • Adds AES-GCM-SIV (RFC 8452) as an AEAD variant to the AES family
  • Adds XChaCha20-Poly1305 to ChaCha20 family variants (not mentioned in PR description)
  • Removes BLAKE2b-HMAC variant (not mentioned in PR description)
  • Fixes spelling errors in TUAK patterns (TUAC -> TUAK)
  • Fixes typo in bcrypt pattern (closing parenthesis -> closing brace)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@stevespringett stevespringett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the pattern based on the suggestion from @bhess

Copy link
Member

@stevespringett stevespringett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Could you resolve the issue that @bhess mentioned? Once corrected, we'll merge this in. Thanks again

@Mehrn0ush Mehrn0ush force-pushed the feat/crypto-registry-aes-gcm-siv branch 2 times, most recently from c36a357 to 52a3a59 Compare January 23, 2026 01:25
Signed-off-by: Mehrn0ush <mehrnoush.vaseghi@gmail.com>
@Mehrn0ush Mehrn0ush force-pushed the feat/crypto-registry-aes-gcm-siv branch from 52a3a59 to f613597 Compare February 12, 2026 13:44
@stevespringett stevespringett merged commit 09d7b33 into CycloneDX:master Feb 19, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cap: cryptography Capability: Cryptography (CBOM) cap: cryptography-registry Capability: Cryptography Registry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE]: Add AES-GCM-SIV AEAD variant in Cryptography Registry

3 participants