KNOX-3158: Enhancing the maintainability of knox-shell

[Raghav-Mah3shwari]

Increasing the maintainability of the code by reducing code smells from gateway-shell

How was this patch tested?

The changes were made in local first then a maven build was triggered. The build was successful

[lmccay]

@Raghav-Mah3shwari - please show that you have tested the shell functionality related to the changes that you have made. We need to know that there has been some manual testing for the shell work since much of that is hard to unit test. Some example output exercising the the affected code paths would be a good way to do this.

[Raghav-Mah3shwari]

Hi @lmccay can you give me some suggestions on how to test it and verify it. Thanks in advance

[smolnar82]

Please use Knox's MesageFactory feature and the relevant interface (in this case this would be org.apache.knox.gateway.shell.KnoxShellMessages) instead of the plain Logger approach.

[smolnar82]

@Raghav-Mah3shwari — This PR has been inactive for some time.
If you still plan to work on it, please address the review comments and request a new review.
Otherwise, we will close it on 27 Feb 2026.