Skip to content

Clean up formatting and add change password to accounts page#625

Merged
Sahil590 merged 2 commits into542-base-templatefrom
account-page-cleanup
Mar 12, 2026
Merged

Clean up formatting and add change password to accounts page#625
Sahil590 merged 2 commits into542-base-templatefrom
account-page-cleanup

Conversation

@AdrianDAlessandro
Copy link
Collaborator

Description

A couple of changes I noticed were required when reviewing #617 (this currently merges into that branch)

Explained:

  • Adding bg-secondary back to the account pages, which was inadvertently removed when making it extend base.html
  • The password change form should be in the accounts page, so I have changed the base form for that and updated the highlight condition so it it clear which page you're on.

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Technical work (non-breaking, change which is work as part of a new feature)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (eg. python -m pytest)
  • The documentation builds and looks OK (eg. mkdocs serve)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added or an issue has been opened to tackle that in the future. (Indicate issue here: # (issue))

@codecov
Copy link

codecov bot commented Mar 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@Sahil590 Sahil590 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sahil590 Sahil590 merged commit 3315041 into 542-base-template Mar 12, 2026
5 checks passed
@Sahil590 Sahil590 deleted the account-page-cleanup branch March 12, 2026 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants