Skip to content

fix(preprod): Remove redundant "apps analyzed" text when size checks … #107292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mtopo27 merged 1 commit into from
Jan 30, 2026
+5 −5
Merged

fix(preprod): Remove redundant "apps analyzed" text when size checks … #107292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/sentry/preprod/vcs/status_checks/size/templates.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ def format_status_check_messages(
raise ValueError("No metrics exist for VCS size status check")

parts = []
if analyzed_count > 0:
if analyzed_count > 0 and not triggered_rules:
parts.append(
ngettext("%(count)d app analyzed", "%(count)d apps analyzed", analyzed_count)
% {"count": analyzed_count}
Expand Down
8 changes: 4 additions & 4 deletions tests/sentry/preprod/vcs/status_checks/size/test_templates.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1289,7 +1289,7 @@ def test_single_triggered_rule_shows_details_section(self):
"""

assert title == "Size Analysis"
assert subtitle == "1 app analyzed"
assert subtitle == ""
assert summary == expected

def test_multiple_triggered_rules_url_formatting(self):
Expand Down Expand Up @@ -1386,7 +1386,7 @@ def test_multiple_triggered_rules_url_formatting(self):
"""

assert title == "Size Analysis"
assert subtitle == "1 app analyzed"
assert subtitle == ""
assert summary == expected

def test_multiple_apps_with_triggered_rules(self):
Expand Down Expand Up @@ -1499,7 +1499,7 @@ def test_multiple_apps_with_triggered_rules(self):
"""

assert title == "Size Analysis"
assert subtitle == "2 apps analyzed"
assert subtitle == ""
assert summary == expected

def test_mixed_pass_fail_with_triggered_rules(self):
Expand Down Expand Up @@ -1602,5 +1602,5 @@ def test_mixed_pass_fail_with_triggered_rules(self):
"""

assert title == "Size Analysis"
assert subtitle == "2 apps analyzed"
assert subtitle == ""
assert summary == expected
Loading