Skip to content

Comments

chore[ci]: explicitly use stable or night for all cargo commands#6553

Merged
joseph-isaacs merged 6 commits intodevelopfrom
ji/remove-nightly
Feb 20, 2026
Merged

chore[ci]: explicitly use stable or night for all cargo commands#6553
joseph-isaacs merged 6 commits intodevelopfrom
ji/remove-nightly

Conversation

@joseph-isaacs
Copy link
Contributor

@joseph-isaacs joseph-isaacs commented Feb 17, 2026

We want to use stable for all ci checks unless nightly is required. This PR does this

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@joseph-isaacs joseph-isaacs changed the title wip wip: ci audit Feb 17, 2026
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Feb 18, 2026

Deploying vortex-bench with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1527dac
Status: ✅  Deploy successful!
Preview URL: https://62e3d8ea.vortex-93b.pages.dev
Branch Preview URL: https://ji-remove-nightly.vortex-93b.pages.dev

View logs

@joseph-isaacs joseph-isaacs changed the title wip: ci audit chore[ci]: explicitly use stable or night for all cargo commands Feb 18, 2026
@joseph-isaacs joseph-isaacs requested a review from 0ax1 February 18, 2026 10:22
@joseph-isaacs joseph-isaacs marked this pull request as ready for review February 18, 2026 10:22
@joseph-isaacs joseph-isaacs added the changelog/chore A trivial change label Feb 18, 2026
@joseph-isaacs joseph-isaacs requested a review from AdamGS February 18, 2026 10:24
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Copy link
Contributor

@robert3005 robert3005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes so we don't break publish

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Set the NIGHTLY_TOOLCHAIN environment variable for the workflow.

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@joseph-isaacs joseph-isaacs merged commit 6289f39 into develop Feb 20, 2026
51 of 52 checks passed
@joseph-isaacs joseph-isaacs deleted the ji/remove-nightly branch February 20, 2026 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants