Fix ThemeProvider context mismatch in shadow-root modal providers#587
Open
bunnybones1 wants to merge 1 commit intomasterfrom
Open
Fix ThemeProvider context mismatch in shadow-root modal providers#587bunnybones1 wants to merge 1 commit intomasterfrom
bunnybones1 wants to merge 1 commit intomasterfrom
Conversation
Deploying web-sdk-react-example with
|
| Latest commit: |
863b802
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://95751280.web-sdk-react-example.pages.dev |
| Branch Preview URL: | https://fix-theme-provider.web-sdk-react-example.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Some integrations hit:
useTheme must be called within a ThemeProviderwhile using
@0xsequence/connect,@0xsequence/checkout, and@0xsequence/wallet-widgettogether.Root cause
ShadowRoot(in@0xsequence/connect) always createdThemeProviderinternally.checkoutandwallet-widgetrender design-system components in that shadow root. Depending on module resolution/install shape, this can cause a React context/module split and makeuseThemeresolve outside the expected provider instance.Fix
ShadowRootso callers can receive the shadow container.ThemeProviderinsideShadowRootusing the passed container:SequenceConnectProviderSequenceConnectInlineProviderSequenceCheckoutProviderSequenceWalletProviderWhy this works
It removes the implicit cross-package provider coupling and ensures modal trees are wrapped by the provider instance associated with the package rendering those components.
Notes
@0xsequence/design-systemsetup.@0xsequence/hooks/@0xsequence/connectmodule resolution).