Skip to content

fix: CSV Injection in Application Chat Export #4940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaohuzhang1 merged 1 commit into from
Mar 25, 2026
+2 −0
Merged

fix: CSV Injection in Application Chat Export #4940

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions apps/application/serializers/application_chat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,8 @@ def to_row(row: Dict):
def reset_value(value):
if isinstance(value, str):
value = re.sub(ILLEGAL_CHARACTERS_RE, '', value)
if value.startswith(('=', '+', '-', '@')):
value = "'" + value
if isinstance(value, datetime.datetime):
eastern = pytz.timezone(TIME_ZONE)
c = datetime.timezone(eastern._utcoffset)
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's a concise review of the provided code:

  1. Line 204:

    • c = datetime.timezone(eastern._utcoffset)
      This line is redundant as eastern is already timezone-aware, so _utcoffset() would return zero.

  2. Potential Optimization:

    • Consider using Python string methods directly within regular expressions to simplify filtering out illegal characters.

  3. Comments and Readability:

    • Add comments to explain the purpose of each function or block of code for better readability. For example: 
      # Reset the value to remove certain illegal characters (e.g., '=', '+', '-', '@')

Revised Code

def to_row(row: Dict):
    def reset_value(value):
        if isinstance(value, str):
            # Remove leading special characters ('=', '+', '-', '@') by single quoting them
            value = re.sub(r'^(['=+\-@])', r"'", value)
        if isinstance(value, datetime.datetime):
            eastern = pytz.timezone('US/Eastern')  # Assuming US/Eastern is your time zone
            c = eastern.utcoffset(datetime.datetime.now())
        # Further processing...

Note:

  • The revised code removes unnecessary operations and provides more meaningful comments to enhance clarity.
  • Make sure to adjust the timezone used (pytz.timezone('US/Eastern')) based on your actual requirements.

Expand Down
Loading