reverse logic for DropValue filters#232
Merged
tennlee merged 2 commits intoACCESS-Community-Hub:developfrom Mar 6, 2026
Merged
reverse logic for DropValue filters#232tennlee merged 2 commits intoACCESS-Community-Hub:developfrom
tennlee merged 2 commits intoACCESS-Community-Hub:developfrom
Conversation
This aligns the logic with the doc strings. Now a PipelineFilterException is raised when the number of values in the input is equal to or greater than the supplied percentage threshold. Before, the exception would be raised if the number of values is strictly less than the supplied threshold.
Pull Request Test Coverage Report for Build 20800831494Details
💛 - Coveralls |
nikeethr
reviewed
Jan 12, 2026
packages/pipeline/src/pyearthtools/pipeline/operations/dask/filters.py
Outdated
Show resolved
Hide resolved
Collaborator
|
The change itself seems fine, the difficulty I'm having is the flag (bool) according to docstring and whether True => exception or False => exception, and that's more my lack of understanding probably. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This aligns the logic with the doc strings and resolves #231. Now a PipelineFilterException is raised when the number of values in the input sample is equal to or greater than the supplied percentage threshold. Before, the exception would be raised if the number of values is strictly less than the supplied threshold.