Add pipeline value operations tests#234
Merged
tennlee merged 15 commits intoACCESS-Community-Hub:developfrom Mar 6, 2026
Merged
Add pipeline value operations tests#234tennlee merged 15 commits intoACCESS-Community-Hub:developfrom
tennlee merged 15 commits intoACCESS-Community-Hub:developfrom
Conversation
Clip is more appropriate as there is an equivalent dask/numpy/xarray function. Additionally, no normalisation is occuring.
This aligns xarray FillNan with numpy FillNan
Clip is more appropriate as there is an equivalent dask/numpy/xarray operation.
when creating a new variable with Derive, the new variable was being added to the input dataset. This commit fixes that by making a shallow copy of the input and adding the variables to that shallow copy before returning it.
Clip is more appropriate as there is an equivalent dask/numpy/xarray operation.
Pull Request Test Coverage Report for Build 22118023831Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
nikeethr
reviewed
Jan 12, 2026
Collaborator
|
Thanks for the changes. Just had a minor comment (see above). Otherwise, it looks good. appreciate the comments around deep copy and what they affect. Given that lot of applications of the pipeline can be memory hungry |
tennlee
reviewed
Jan 16, 2026
tennlee
reviewed
Jan 16, 2026
tennlee
reviewed
Jan 16, 2026
tennlee
reviewed
Mar 6, 2026
packages/pipeline/src/pyearthtools/pipeline/operations/xarray/values.py
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests covers all the operation classes in
operations/{dask,numpy,xarray}/values.py. Some important changes:NotImplementedError, and just needed to add a missing arg inda.nan_to_numto make it work.Replaceclass instead ofreplace_valueclass frompyearthtool.data.transforms.maskasreplace_valuedoesn't exist anymore.xarray.DerivewhereDerive.apply_funcwas also updating the input dataset.pyearthtools.data.transforms.deriveby replacing the deprecatedDataset.dropwithDataset.drop_vars