Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
dipannita08
requested review from
A9isha,
NicoGrande,
NuojCheng,
RissyRan,
SurbhiJainUSC,
aireenmei,
bvandermoon,
gagika,
gobbleturk,
hengtaoguo,
igorts-git,
jesselu-google,
jiangjy1982,
khatwanimohit,
parambole,
richjames0,
shralex,
suexu1025 and
vipannalla
as code owners
Collaborator
There was a problem hiding this comment.
Add post_training marker to sft_hooks_test.py
Collaborator
There was a problem hiding this comment.
Should we move all post_training tests to tests/post_training/unit and tests/post_training/integration?
Collaborator
Author
There was a problem hiding this comment.
Sounds like a good idea to me. Need another small restructure for that.
dipannita08
force-pushed
the
post-training-ci-gate
branch
from
1e2a950 to
6008d3b
Compare
dipannita08
force-pushed
the
post-training-ci-gate
branch
from
6008d3b to
1f97d24
Compare
bvandermoon
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add cpu and tpu post training tests to CI.
FIXES: b/491236090
Tests
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.