Update omp detection for macOS #15040
Conversation
Updated OpenMP detection for macOS with hints to brew library paths and set required compile flags.
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
Added copyright and licensing information to FindOpenMPMacOS.cmake.
dependencies/FindOpenMPMacOS.cmake
Outdated
| NAMES omp libomp | ||
| HINTS | ||
| /opt/homebrew/opt/libomp/lib | ||
| /opt/homebrew/lib |
There was a problem hiding this comment.
You should not have "/opt/homebrew/lib" or "/usr/local/lib" in the hints. If that happens to be selected, then it becomes impossible to override single packages. I would prefer if the OpenMP support and detection is driven from the outside.
There was a problem hiding this comment.
thanks. Just to understand /opt/homebrew/opt/libomp/lib is fine though, no right? How do you imagine the support be driven from the outside, in the recipe?
There was a problem hiding this comment.
Yes, /opt/homebrew/opt/libomp/lib is fine. For support driven from the outside I mean via some -DOPENMP_DIR=$(brew --prefix libomp)
ktf
left a comment
ktf
left a comment
There was a problem hiding this comment.
See inline comment. Do not provide hints pointing to common system folders.
|
@ktf, I removed the system paths, the failure in o2_slc9 is not clear to me since the the log shows that everything is good. |
2 participants
Updated OpenMP detection for macOS with hints to brew/usr library paths and set required compile flags. This correctly picks it up at least on my system.