Cron tab: Improve UI for rendering scheduled crons #108447
Open
+42
−72
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DOTCOM-15893
Proposed Changes
I added
cronstruelib to render human-readable cron times.Also added description to be explicit that the specific time of execution is randomized.
Why are these changes being made?
While creating new cron - we send "Daily' etc, but backend stores it as raw cron format. After discussion with implementors of the API - it seems that we had to try to do our best to make UI good with the state of things which we have right now.
The discussion - p9o2xV-5WN-p2#comment-12339
I was thinkign about what we can do and I propose to go with the first step as:
See screenshots below.
As the second step, I am going to continue the conversation (p9o2xV-5WN-p2#comment-12339) and try to convince teh team that it will be more rational if they store the requested format at teh server, alongside the command and raw cron time. Hopefully that they will agree and we will make UI much more better. But ATM, what I proposed, I suppose is teh best option, what we can do.
Testing Instructions