fix: update foreign key handling to use 'reference'#25
Merged
Conversation
…es' instead of 'reference' for consistency and compatibility
…ency in foreign key handling
…onsistency with foreign key handling
…e legacy reference property in createColumns
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
…ved compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
instead of 'reference' for consistency and compatibility
Note
Low Risk
Mostly a naming/compatibility change in SQL generation for foreign keys; risk is limited to callers that still pass
referenceand could hit validation/undefined access if not covered.Overview
Foreign key definitions are standardized to use
referencesinstead ofreferenceinManageSQLBuilder.createForeignKeyand tablecreateColumnsnow validate/render fromoptions.referencesand normalizeonDelete/onUpdate(defaulting toNO ACTION), whilecreateColumnsandmigration.createForeignKeyaccept the legacyreferencefield by mapping it toreferences. Tests were updated to usereferencesand a new test was added to ensure legacyreferencestill works.Written by Cursor Bugbot for commit ac909d1. This will update automatically on new commits. Configure here.