Open
Conversation
When unprotecting txs, we were not running the check for allowed public setup functions, which was skipped in the reqresp entrypoint. This commit now tracks whether public setup is allowed or not for a tx in the tx metadata, and uses it to drop the tx when it becomes unprotected. An alternative approach would have been to store the entire public setup calls in the tx metadata, but this means a smaller memory footprint.
#21399) ## Summary - Fixed inverted boolean comparison in `message_delivery.nr` line 208 that caused `ONCHAIN_CONSTRAINED` to run encryption unconstrained and vice versa. - The check was comparing against `ONCHAIN_UNCONSTRAINED` instead of `ONCHAIN_CONSTRAINED`, flipping the condition passed to `remove_constraints_if`. ## Backport This is a backport fix targeting `v4-next` via `merge-train/fairies`. ## Test plan - [ ] Verify constrained encryption is actually constrained when using `ONCHAIN_CONSTRAINED` delivery mode - [ ] Verify unconstrained encryption when using `ONCHAIN_UNCONSTRAINED` delivery mode cc @nventuro for review ClaudeBox log: https://claudebox.work/s/c8cf1c507575d776?run=3
2 tasks
…ackport #20919) (#21434) ## Summary Backport of #20919 to v4-next. Adds `ETHEREUM_HTTP_TIMEOUT_MS` env var to configure the timeout for viem HTTP transports used in L1 RPC calls. Introduces `makeL1HttpTransport` helper to centralize transport creation with consistent timeout support. ## Conflict Resolution Cherry-pick had a conflict in `blob-client/src/client/http.ts` because `next` had refactored `getSlotNumber` to accept `parentBeaconBlockRoot` as a parameter. Resolved by keeping the v4-next code structure and applying only the transport change (`makeL1HttpTransport` with timeout support). ## Commits 1. Cherry-pick with conflict markers (for reviewability) 2. Conflict resolution ClaudeBox log: https://claudebox.work/s/02b67d20aae96377?run=2 --------- Co-authored-by: Santiago Palladino <[email protected]>
Collaborator
Author
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
fix(tx): reject txs with invalid setup when unprotecting (#21224)
END_COMMIT_OVERRIDE