Skip to content

Comments

Upgrade ESLint to v10#453

Merged
mikeharder merged 8 commits intomainfrom
copilot/upgrade-eslint-to-v10
Feb 20, 2026
Merged

Upgrade ESLint to v10#453
mikeharder merged 8 commits intomainfrom
copilot/upgrade-eslint-to-v10

Conversation

Copy link
Contributor

Copilot AI commented Feb 20, 2026

Upgrade ESLint from v9 to v10 and update related packages for compatibility, similar to Azure/avocado#271.

  • Dependencies: eslint^10.0.0, @eslint/js^10.0.0, typescript-eslint^8.56.0, added globals ^17.3.0 (previously transitive via @eslint/eslintrc, removed in v10)
  • no-useless-assignment fix (src/lib/util/utils.ts): Refactored parseContent() to early-return instead of assigning to a mutable let result
  • preserve-caught-error suppression (eslint.config.js): New v10 recommended rule requiring { cause } on re-thrown errors. Disabled because the project targets ES2017 and TypeScript lacks the ErrorOptions type at that target level. Consistent with the existing pattern of suppressed rules from the tslint migration.
  • Node engine bump (package.json): Updated engines.node from >=20.0.0 to >=20.19.0 to align with ESLint v10's engine requirement (^20.19.0 || ^22.13.0 || >=24)

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Co-authored-by: mikeharder <9459391+mikeharder@users.noreply.github.com>
Copilot AI changed the title [WIP] Upgrade eslint to version 10 Upgrade ESLint to v10 Feb 20, 2026
Copilot AI requested a review from mikeharder February 20, 2026 09:02
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Upgrades the repo’s linting toolchain to ESLint v10 and aligns related TypeScript ESLint packages/config, with a small refactor to satisfy updated lint rules.

Changes:

  • Bump eslint / @eslint/js to v10 and typescript-eslint to ^8.56.0; add globals as an explicit devDependency.
  • Refactor parseContent() to use early returns (avoids no-useless-assignment).
  • Disable ESLint v10’s preserve-caught-error rule in eslint.config.js due to ES2017 / typing constraints.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/lib/util/utils.ts Refactors parseContent() control flow to satisfy updated linting rules.
package.json Updates ESLint-related devDependencies and adds globals.
package-lock.json Locks upgraded ESLint/TypeScript-ESLint dependency graph.
eslint.config.js Disables new v10 recommended rule preserve-caught-error with rationale.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mikeharder
Copy link
Member

@copilot apply changes based on the comments in this thread

@mikeharder mikeharder enabled auto-merge (squash) February 20, 2026 19:10
Co-authored-by: mikeharder <9459391+mikeharder@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Feb 20, 2026

@copilot apply changes based on the comments in this thread

Applied the Node engine bump in 55425b5engines.node updated from >=20.0.0 to >=20.19.0 to match ESLint v10's requirements.

@mikeharder mikeharder merged commit 0bbc6d2 into main Feb 20, 2026
8 checks passed
@mikeharder mikeharder deleted the copilot/upgrade-eslint-to-v10 branch February 20, 2026 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🔬 Dev in PR

Development

Successfully merging this pull request may close these issues.

3 participants