Conversation
Co-authored-by: mikeharder <9459391+mikeharder@users.noreply.github.com>
mikeharder
reviewed
Feb 20, 2026
mikeharder
reviewed
Feb 20, 2026
mikeharder
reviewed
Feb 20, 2026
mikeharder
reviewed
Feb 20, 2026
There was a problem hiding this comment.
Pull request overview
Upgrades the repo’s linting toolchain to ESLint v10 and aligns related TypeScript ESLint packages/config, with a small refactor to satisfy updated lint rules.
Changes:
- Bump
eslint/@eslint/jsto v10 andtypescript-eslintto^8.56.0; addglobalsas an explicit devDependency. - Refactor
parseContent()to use early returns (avoidsno-useless-assignment). - Disable ESLint v10’s
preserve-caught-errorrule ineslint.config.jsdue to ES2017 / typing constraints.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/lib/util/utils.ts | Refactors parseContent() control flow to satisfy updated linting rules. |
| package.json | Updates ESLint-related devDependencies and adds globals. |
| package-lock.json | Locks upgraded ESLint/TypeScript-ESLint dependency graph. |
| eslint.config.js | Disables new v10 recommended rule preserve-caught-error with rationale. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
raych1
approved these changes
Feb 20, 2026
Member
|
@copilot apply changes based on the comments in this thread |
Co-authored-by: mikeharder <9459391+mikeharder@users.noreply.github.com>
Contributor
Author
Applied the Node engine bump in 55425b5 — |
mikeharder
approved these changes
Feb 20, 2026
raych1
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade ESLint from v9 to v10 and update related packages for compatibility, similar to Azure/avocado#271.
eslint→^10.0.0,@eslint/js→^10.0.0,typescript-eslint→^8.56.0, addedglobals^17.3.0(previously transitive via@eslint/eslintrc, removed in v10)no-useless-assignmentfix (src/lib/util/utils.ts): RefactoredparseContent()to early-return instead of assigning to a mutablelet resultpreserve-caught-errorsuppression (eslint.config.js): New v10 recommended rule requiring{ cause }on re-thrown errors. Disabled because the project targets ES2017 and TypeScript lacks theErrorOptionstype at that target level. Consistent with the existing pattern of suppressed rules from the tslint migration.package.json): Updatedengines.nodefrom>=20.0.0to>=20.19.0to align with ESLint v10's engine requirement (^20.19.0 || ^22.13.0 || >=24)🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.