Fix falling animation when clicking input fields in settings#622
Merged
Fix falling animation when clicking input fields in settings#622
Conversation
When MovementLock was active (e.g. input field focused), the walk mode zeroed the entire move vector including gravity. CharacterController.Move with zero vector meant no downward push, so isGrounded returned false on the next frame. After the 0.1s grace period the falling animation played. Only zero horizontal movement now, preserving the vertical gravity component so the character stays grounded while typing. Co-Authored-By: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BasisWalkMovementMode.Tick()zeroed the entire move vector (move = Vector3.zero) whenMovementLockwas active (input field focused), including the gravity/vertical componentCharacterController.Move(Vector3.zero)produces no downward collision, soisGroundedreturns false on the next frame. After the 0.1sfallingGracePeriod,IsFallingbecomes true and the falling animation playsmove.x = 0; move.z = 0), preserving the vertical gravity component so the character stays grounded while the input field has focusTest plan
🤖 Generated with Claude Code