fix jet docs for build_tapleaf_simplicity#229
Open
stringhandler wants to merge 1 commit intoBlockstreamResearch:masterfrom
Open
fix jet docs for build_tapleaf_simplicity#229stringhandler wants to merge 1 commit intoBlockstreamResearch:masterfrom
stringhandler wants to merge 1 commit intoBlockstreamResearch:masterfrom
Conversation
delta1
approved these changes
Mar 9, 2026
Collaborator
delta1
left a comment
There was a problem hiding this comment.
ACK 132bfc0; documentation review
Looks correct from my reading of the source: https://github.com/BlockstreamResearch/simplicity/blob/master/C/elements/ops.c#L133
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docs for
build_tapleaf_simplicityseemed to be copied frombuild_tapbranch_simplicity. I think these are correct now.