Draft
Conversation
Replace actor-level coloring with cell-based coloring. This allows distinct colors per cell type (vertices, edges, faces) rather than one color per actor.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2006 +/- ##
=======================================
Coverage 96.08% 96.08%
=======================================
Files 29 29
Lines 7961 7961
Branches 1190 1190
=======================================
Hits 7649 7649
Misses 179 179
Partials 133 133 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| reader.parseAsArrayBuffer(textEncoder.encode(shape)); | ||
|
|
||
| // setup actor,mapper and add | ||
| // create mesh types based on cell type for coloring |
Member
There was a problem hiding this comment.
Shouldn't we just reuse the approach of fig/show of splitting into two actors on python side?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace actor-level coloring with cell-based coloring. This allows distinct colors per cell type (vertices, edges, faces) rather than one color per actor.