Merged
Conversation
* Use USER_FILE_UPDATED for group global_file_updated * Use REVIEWS_SUBMISSION_STATUS for group global_reviews
…fails with permission error
remove datetime
[ENG-10083] Add type and is_digest "relation" and update subscription
…for functionality
…_sync_task [ENG-10076] Add Celery task to delete removed beat tasks from PeriodicTask entries
…pe-defenitions [ENG-9923] Sync naming of notifications
…actor notification model
…migration [ENG-10496] Fix migration due to postgres limitation
[ENG-9923] Removed comment
[ENG-10535] Update the no_login mail send conditions
…tifications-refactor-with-develop
…EmailTasks and recent no-login emails
[ENG-10535] Update the no_login mail send conditions
…refactor-with-develop [ENG-10530] Merge notifications refactor with develop after ROR release
Collaborator
Author
Ostap-Zherebetskyi
left a comment
Ostap-Zherebetskyi
left a comment
There was a problem hiding this comment.
LGTM ⭐
…ifications [ENG-10547] Collections: Project link pointing to api request instead of FE overview for all add/remove to collection notifications
…ifications [ENG-10547] Collections: fix logo url
…e_notification_types_to_admin [ENG-10570] Add management command to sync notification templates in admin
…files to CeleryConfig
[ENG-10611] Add delete_withdrawn_or_failed_registration_files import
…st_logo [ENG-10547] Fix collections digest logo
cslzchen
changed the title
cslzchen
approved these changes
Mar 13, 2026
Collaborator
cslzchen
left a comment
cslzchen
left a comment
There was a problem hiding this comment.
⭐ LGTM, my comments are for code clean-up only. Let's take care of the code clean-up after release as a separate squash merge commit.
|
|
||
|
|
||
| @celery_app.task(name='scripts.remove_after_use.populate_notification_subscriptions_node_file_updated') | ||
| def populate_notification_subscriptions_node_file_updated(batch_size: int = 1000): |
Collaborator
There was a problem hiding this comment.
No longer needed since we have the create-on-missing fix.
| print('----Creation finished----') | ||
|
|
||
| @celery_app.task(name='scripts.remove_after_use.update_notification_subscriptions_node_file_updated') | ||
| def update_notification_subscriptions_node_file_updated(): |
Collaborator
There was a problem hiding this comment.
No longer needed since our de-duplication v2 command already fix the _id_digest issue.
| from osf.models import OSFUser, NotificationSubscription, NotificationTypeEnum | ||
|
|
||
| @celery_app.task(name='scripts.remove_after_use.populate_notification_subscriptions_user_global_file_updated') | ||
| def populate_notification_subscriptions_user_global_file_updated(per_last_years: int | None= None, batch_size: int = 1000): |
Collaborator
There was a problem hiding this comment.
Same, no longer needed since we have the create-on-missing fix.
| print('----Creation finished----') | ||
|
|
||
| @celery_app.task(name='scripts.remove_after_use.update_notification_subscriptions_user_global_file_updated') | ||
| def update_notification_subscriptions_user_global_file_updated(): |
Collaborator
There was a problem hiding this comment.
Same, no longer needed since our de-duplication v2 command already fix the _id_digest issue.
| print('----Creation finished----') | ||
|
|
||
| @celery_app.task(name='scripts.remove_after_use.update_notification_subscriptions_user_global_reviews') | ||
| def update_notification_subscriptions_user_global_reviews(): |
Collaborator
There was a problem hiding this comment.
Same, no longer needed since our de-duplication v2 command already fix the _id_digest issue.
Comment on lines
-1715
to
+1720
| Rule( | ||
| '/subscriptions/', | ||
| 'get', | ||
| notification_views.get_subscriptions, | ||
| json_renderer, | ||
| ), | ||
| # Legacy v1 API for notifications, which is no longer used by Angular/Post-NR | ||
| # Rule( | ||
| # '/subscriptions/', | ||
| # 'get', | ||
| # notification_views.get_subscriptions, | ||
| # json_renderer, | ||
| # ), |
Collaborator
There was a problem hiding this comment.
Should be safe to remove now
Comment on lines
-1722
to
+1731
| Rule( | ||
| [ | ||
| '/project/<pid>/subscriptions/', | ||
| '/project/<pid>/node/<nid>/subscriptions/' | ||
| ], | ||
| 'get', | ||
| notification_views.get_node_subscriptions, | ||
| json_renderer, | ||
| ), | ||
| # Legacy v1 API for notifications, which is no longer used by Angular/Post-NR | ||
| # Rule( | ||
| # [ | ||
| # '/project/<pid>/subscriptions/', | ||
| # '/project/<pid>/node/<nid>/subscriptions/' | ||
| # ], | ||
| # 'get', | ||
| # notification_views.get_node_subscriptions, | ||
| # json_renderer, | ||
| # ), |
Comment on lines
-1742
to
+1749
| Rule( | ||
| '/subscriptions/', | ||
| 'post', | ||
| notification_views.configure_subscription, | ||
| json_renderer, | ||
| ), | ||
| # Legacy v1 API for notifications, which is no longer used by Angular/Post-NR | ||
| # Rule( | ||
| # '/subscriptions/', | ||
| # 'post', | ||
| # notification_views.configure_subscription, | ||
| # json_renderer, | ||
| # ), |
| from osf.models import NotificationSubscription, NotificationType, NotificationTypeEnum | ||
|
|
||
|
|
||
| class Command(BaseCommand): |
Collaborator
There was a problem hiding this comment.
Not this v2 one. We can remove the old de-duplication command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
Purpose
Changes
Side Effects
QE Notes
CE Notes
Documentation