fix: select name for editing when creating new files or folders #2159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes CodeEditApp#2029 When creating a new file or folder via the context menu, the name is now automatically selected for editing. This matches the expected macOS UX behavior where new items can be immediately renamed. Changes: - Added renameFile() call after creating new file in newFile() - Added renameFile() call after creating new folder in newFolder() Note: The newFileFromClipboard() already had this behavior, this makes the other creation methods consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2029
When creating a new file or folder via the context menu, the name is now automatically selected for editing. This matches the expected macOS UX behavior where new items can be immediately renamed.
Changes
renameFile()call after creating new file innewFile()renameFile()call after creating new folder innewFolder()Notes
The
newFileFromClipboard()method already had this behavior - this makes the other creation methods consistent.Testing