Sheffield | 25-SDC-Nov | Hassan Osman | Sprint 1 | Can't log in from profile page#142
Open
HassanOHOsman wants to merge 1 commit intoCodeYourFuture:mainfrom
Open
Sheffield | 25-SDC-Nov | Hassan Osman | Sprint 1 | Can't log in from profile page#142HassanOHOsman wants to merge 1 commit intoCodeYourFuture:mainfrom
HassanOHOsman wants to merge 1 commit intoCodeYourFuture:mainfrom
Conversation
HassanOHOsman
added
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
In this pull request I fixed the login flow on profile pages by changing the login handler from a click event to a form submit event, ensuring re-login correctly renders the profile without triggering a 405 error.