Manchester | 25-SDC-Nov | Rahwa Haile | Sprint 1 | Bug Report: Extra long blooms?#143
Open
RahwaZeslusHaile wants to merge 3 commits intoCodeYourFuture:mainfrom
Open
Manchester | 25-SDC-Nov | Rahwa Haile | Sprint 1 | Bug Report: Extra long blooms?#143RahwaZeslusHaile wants to merge 3 commits intoCodeYourFuture:mainfrom
RahwaZeslusHaile wants to merge 3 commits intoCodeYourFuture:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manchester | 25-SDC-Nov | Rahwa Haile | Sprint 1 | Bug Report: Extra long blooms?
Learners, PR Template
Self checklist
Fix: Enforce 280-character limit on blooms
Description
This PR fixes a bug where blooms could be posted with content exceeding the intended 280-character limit. The frontend enforces this limit via a textarea
maxlengthattribute, but the backend had no validation, allowing blooms to bypass the restriction.Changes
send_bloom()endpoint to reject blooms longer than 280 characters with a 400 error responseWhy This Matters
Testing
Please review my work — thank you!