West Midlands | Jan26 ITP | Ziad Ahmed | sprint 2 | Form Controls

[ZiadMakkawi]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

Added the form based on the required assesment

The orginal work for some reason was deleted and i had to do it again
This is fixed now
Added Autocompelete and validation
Validation message now match the proper format

[netlify]

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	1f5522c
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/6995021daecd9500081b8484
😎 Deploy Preview	https://deploy-preview-1157--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 87 (🟢 up 1 from production) PWA: - View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[ZiadMakkawi]

So the reason why my code only shows a small section being edited .Because, my first commit i ended up commiting the wireframe files with the Form ones so i had to redo the commits and the Pull Request

[SlideGauge]

Looks like no form is implemented in this PR, could you implement it please?

[cjyuan]

@ZiadMakkawi

Please note that in CYF courses, the recommended way to inform the reviewer of your changes is to do both of the following:

• Reply to their feedback.
  • In the responses, clarify how each piece of feedback was addressed to demonstrate that you've carefully reviewed the suggestions.
    • You may find the suggestions in this PR Guide useful.
  • Your response may trigger a notification (depending on the reviewer's settings), helping ensure they’re aware of the updates you’ve made.
• Replace the "Reviewed" label by a "Needs review" label (which you have done -- great!)
  • Without this label, the reviewer would not know if your changes is ready to be reviewed.

[ZiadMakkawi]

The form changes weren't implemented because I accidentally deleted the commit history and pushed the version before the changes were added, resulting in an empty form.
This should be fixed now.

[jayshreehajgude2012]

You can use autocomplete property for form fields like name, email.
You can use validation message as title of the field.

[ZiadMakkawi]

The autocomplete attribute for form fields (such as name and email) and the inclusion of validation messages via the title attribute are they recommendations or strict requirements ?
Regardless Ill add them