London |26-ITP-january | Dagim Daniel | Sprint 1 | wireframe

[Dagim-Daniel]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

[netlify]

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	52df496
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/699212723f5f8600087fe27a
😎 Deploy Preview	https://deploy-preview-1174--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 96 (🔴 down 4 from production) SEO: 86 (no change from production) PWA: - View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[cjyuan]

The Validation bot will complain about any changed files not in the Wireframe folder.

Can you revert the changes made to the readme.md file in the top-level folder? If you are unsure how to revert the file, you can also create a new branch and submit a new PR (and then close this PR).

[cjyuan]

Can you take a look at this General Feedback to see if there
is anything you can do to make your PR more robust and ready?

Code is free of syntax errors! Well done.

Some areas that can be improved include

• Indentation of the code
• Typos
• Structure the page to better match the wireframe image. In particulars, align the image height between articles 2 and 3.

[cjyuan]

• Good job in reverting your first commit. But since your 2nd commit also modified readme.md, the file remains modified.

You can execute the following commands to restore readme.md to the state before your first commit:

git restore --source=3725052 readme.md
git commit -m "Restore readme.md to its original state"

where 3725052 is the hash of the commit made before your first commit (that commit was made on CYF's main).

---

Once you have successfully revert the changes made to readme.md, please refer to my previous comment about how to improve your Wireframe implementation.

[cjyuan]

Code is syntax error free. Page looks good. Well done.

Can you improve the indentation of the HTML code? Doing so can make the code easier to read.

You can try the VSCode's "Format Document" feature. It can help us format our code for better readability and consistency. To use the feature, right-click inside the code editor and select the option.