Skip to content

Manchester| 26-ITP-Jan | Ofonime Edak| Sprint 1| wireframe#1176

Open
Ofonimeedak wants to merge 6 commits intoCodeYourFuture:mainfrom
Ofonimeedak:feat-Wireframe
Open

Manchester| 26-ITP-Jan | Ofonime Edak| Sprint 1| wireframe#1176
Ofonimeedak wants to merge 6 commits intoCodeYourFuture:mainfrom
Ofonimeedak:feat-Wireframe

Conversation

@Ofonimeedak
Copy link

@Ofonimeedak Ofonimeedak commented Feb 14, 2026 •
edited
Loading

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • I have made changes to the html file and CSS file
  • I have used semantic tags where necessary
  • My lighthouse accessibility is 100%
  • I have effected a change in the site layout using flexbox

Briefly explain your PR

This PR contains refactored HTML and CSS files, with the right semantic tag for each section of the code.
This PR also demonstrates a basic understanding of interpreting wireframes into code.

@github-actions

This comment has been minimized.

Sign in to view
@netlify
Copy link

netlify bot commented Feb 14, 2026 •
edited
Loading

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 0e5962a
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/69923935950cfb0008e2dea5
😎 Deploy Preview https://deploy-preview-1176--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@Ofonimeedak Ofonimeedak added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 14, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 14, 2026
@github-actions

This comment has been minimized.

Sign in to view
@Ofonimeedak Ofonimeedak added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 14, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 14, 2026
@github-actions

This comment has been minimized.

Sign in to view
@Ofonimeedak Ofonimeedak added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Onboarding The name of the module. labels Feb 14, 2026
@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 14, 2026
@Ofonimeedak Ofonimeedak added 🏕 Priority Mandatory This work is expected 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 14, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 14, 2026
@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

This comment has been minimized.

Sign in to view
@Ofonimeedak Ofonimeedak added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 14, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 14, 2026
@Ofonimeedak Ofonimeedak changed the title Manchester| ITP-Jan 26 | Ofonime Edak| Sprint 1| Wireframes Manchester| ITP-Jan 26 | Ofonime Edak| Sprint 1| module-onboarding |wireframe Feb 14, 2026
@github-actions

This comment has been minimized.

Sign in to view
@Ofonimeedak Ofonimeedak added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 14, 2026
@Ofonimeedak Ofonimeedak changed the title Manchester| 26 ITP Jan | Ofonime Edak| Sprint 1| wireframe Manchester| 26-ITP-Jan | Ofonime Edak| Sprint 1| wireframe Feb 14, 2026
@github-actions

This comment has been minimized.

Sign in to view
@Ofonimeedak Ofonimeedak added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 14, 2026
cjyuan
cjyuan reviewed Feb 14, 2026
View reviewed changes
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Can you center the page content? On large screen display, currently the content on the page is left-aligned and part of the page is cut off on the left.
Image

  • According to https://validator.w3.org/, there are errors in your code. Can you fix them?

  • Currently ,the footer content and the article content could overlap. Can you prevent this from happening?

Image
  • To better match the layout in the wireframe, can you align the left/right border of article 1 with the left border of article 2 and right border of article 3 respectively? Currently they are not quite aligned.
Image

Wireframe/style.css
Comment on lines 36 to 46
main{
display: flex;
flex-direction: column;
gap: 15px;
align-items: center;
justify-content: center;
height: auto;
width: 95vw;


}
Copy link
Contributor

@cjyuan cjyuan Feb 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you improve the indentation of the CSS code in this file?

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 14, 2026
@github-actions

This comment has been minimized.

Sign in to view
@Ofonimeedak Ofonimeedak added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 15, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 15, 2026
@Ofonimeedak Ofonimeedak added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 15, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 15, 2026
@github-actions

This comment has been minimized.

Sign in to view
@Ofonimeedak Ofonimeedak added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 15, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 15, 2026
@Ofonimeedak Ofonimeedak added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 15, 2026
@Ofonimeedak Ofonimeedak mentioned this pull request Feb 15, 2026
Open
cjyuan
cjyuan reviewed Feb 15, 2026
View reviewed changes
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code has been greatly improvement! Nice job!

  • According to https://validator.w3.org/, there are two warnings in your code. Can you address them? (Warnings are less critical than *Errors but should also be addressed if possible).

  • The footer content and the article content can overlap. Can you prevent it from happening?

Image

@cjyuan cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 15, 2026
@Ofonimeedak Ofonimeedak added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 15, 2026
@cjyuan
Copy link
Contributor

cjyuan commented Feb 15, 2026

Changes look good. Well done.

Note: You could also use VSCode "Format Document" on CSS code.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Onboarding The name of the module. 🏕 Priority Mandatory This work is expected 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Ofonimeedak @cjyuan