Skip to content

fix: cap srcset against naturalWidth instead of currentWidth #1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fuleinist wants to merge 1 commit into
base: development
Choose a base branch
from
Open

fix: cap srcset against naturalWidth instead of currentWidth #1036

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions assets/js/modules/srcset-detector.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,9 +437,10 @@ export const optmlSrcsetDetector = {
const targetWidth = Math.round(baseWidth * dprValue);
const targetHeight = Math.round(targetWidth / aspectRatio);

// Don't generate 1x DPR variations larger than current size
// Don't generate 1x DPR variations larger than natural image size
// But allow 2x DPR variations for retina displays
if (dprValue === 1 && targetWidth > currentWidth) {
// Fixes: srcset capped at profiling container width (issue #1030)
if (dprValue === 1 && targetWidth > naturalWidth) {
return;
}

Expand Down