Conversation
Fix: case setBounds(null) (don't do "this._bounds = new createjs.Rectangle" after "this._bounds = null"). Maybe we need also always create new rectangle, not using old _bounds (or always return cloned rectangle from getBounds())? In my project I got several bugs related to next code: var boundsToUseLater = myObj.getBounds(); // save current bounds // some code (change myObj then call getBounds()) // use boundsToUseLater - properties x/y/widht/height not the same as they were the save moment
|
Shouldn't the bounds be null if any of those properties (x, y, width or height) are null? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: case setBounds(null) (don't do "this._bounds = new createjs.Rectangle" after "this._bounds = null").
Maybe we need also always create new rectangle, not using old _bounds (or always return cloned rectangle from getBounds())?
In my project I got several bugs related to next code:
var boundsToUseLater = myObj.getBounds(); // save current bounds
// some code (change myObj then call getBounds())
// use boundsToUseLater - properties x/y/widht/height not the same as they were the save moment