Fix DOMElement for retina screens#732
Open
mattcolman wants to merge 11 commits intoCreateJS:masterfrom
Open
Conversation
|
I am encountering this problem too. Can this pull request be accepted? |
|
Can this pull request be accepted? |
|
Is this available in the NextVersion ? I am also facing this issue. |
Member
|
Appreciate the PR -- but the implementation of an internal private class with one method is definitely non-standard. I would recommend just adding this as a method of DOMElement for now, and it might make sense to pull it out into a separate utility function/class (like |
Author
|
I'll take a look at cleaning this up |
Author
|
@lannymcnie cleaned it up. |
|
@lannymcnie I am facing this retina issue. I see there are some conflicts. Can this be resolved? |
varyndev
added a commit
to VarynInc/EaselJS
that referenced
this pull request
Dec 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes DOMElement for retina screens.
For example if you make your canvas retina aware like this:
Then the Easel stage is rendered with crisp text and vector shapes on your retina screen, but DOMElement is positioned and scaled incorrectly.
This PR fixes that.