Open
Conversation
maartenba
approved these changes
Mar 13, 2026
Member
maartenba
left a comment
maartenba
left a comment
There was a problem hiding this comment.
Looks solid!
Note to self: needs duplication into v8 samples folder for now.
bhazen
reviewed
Mar 17, 2026
| CancellationToken ct) | ||
| { | ||
| // Merge default scopes into whatever the document already declares | ||
| var existing = context.Document.Scope?.Split(' ', StringSplitOptions.RemoveEmptyEntries) ?? []; |
Contributor
There was a problem hiding this comment.
It feels a little odd that a method named validate is modifying the contents of what it is being validating
| ClientName = document.ClientName, | ||
| LogoUri = document.LogoUri?.ToString(), | ||
| ClientUri = document.ClientUri?.ToString(), | ||
| RedirectUris = document.RedirectUris?.Select(u => u.ToString()).ToList() ?? [], |
Contributor
There was a problem hiding this comment.
I don't see that we're validating the RedirectUris from the document anywhere. Are there rules in the spec which require anything specific about them?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a sample showing how to implement CIMD in IdentityServer to authenticate MCP clients like VS Code.
Apologies for the large number of files, but most of it is standard IdentityServer and a copy of the weather MCP server.
The interesting dozen or so CIMD-specific files are all in CIMD.IdentityServer/. Everything else is copied from McpDemo with namespace changes.