Add QQC2 Style and the color scheme proposed by jetrotal#237
Open
Ghabry wants to merge 7 commits intoEasyRPG:masterfrom
Open
Add QQC2 Style and the color scheme proposed by jetrotal#237Ghabry wants to merge 7 commits intoEasyRPG:masterfrom
Ghabry wants to merge 7 commits intoEasyRPG:masterfrom
Conversation
…platforms Change Kirigami to static build, figured it out
The linker has a 260 character limit and Kirigami obj files have really long paths Also fix CMakePresets.json being generated in the wrong directory
Is extremely annoying while developing and will be likely replaced with something better
…ents because of low contrast) When KIRIGAMI_FORCE_STYLE=0 it will load the native operation system theme instead Currently unsupported when Kirigami is a dynamic library (Linux). In this case Kirigami looks in a different location we do not control. Not gonna fix this, bet this will be imprved upstream someday. Co-Authored-By: Mauro Junior <45118493+jetrotal@users.noreply.github.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 6. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v2...v6) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [styfle/cancel-workflow-action](https://github.com/styfle/cancel-workflow-action) from 0.8.0 to 0.13.0. - [Release notes](https://github.com/styfle/cancel-workflow-action/releases) - [Commits](styfle/cancel-workflow-action@0.8.0...0.13.0) --- updated-dependencies: - dependency-name: styfle/cancel-workflow-action dependency-version: 0.13.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No functionality changes yet I'm just sending this in small chunks :).
I'm working on integrating the editor layout proposed by Jetrotal (but using Kirigami Themes instead of Basic Theme to have proper integration with their components).
Also the Kirigami components looked bad on Windows and macOS because there is no style available.
Kirigami only has a native style on Linux (via Breeze/KDE).
Lucky for us there is a port of this style via qqc2-breeze-style. This gives a similar base style on Windows/Linux/macOS. (obviously not native on most of them, but what is native these days).
Having a unified style everywhere also makes the development simpler for now, otherwise we waste time fighting styling issues.
This custom style also makes it possible to port the proposed color scheme by jetrotal over (but I had to adjust the contrast to 1:7 contrast as suggested in accesibility guidelines. I had a hard time reading the light gray on dark gray stuff which only had a 1:4 contrast. Maybe jetrotal has a better color vision than me)
After porting the style I disabled it and noticed that qqc2-breeze actually can use the native color schemes. Cool.
So we have two styles now: EasyRPG Theme and Native colors.
The style is currently not working on Linux. Kirigami looks in other directories when it is a shared library and does not load the thema from the resource.
Tested and working on Windows and macOS. (and Linux obviously)
Also figured out how to make Kirigami (and the Breeze Style) static libraries. This made the installation much simpler when using vcpkg. Also should solve the problem with the macOS application signing.