Skip to content

Comments

add stage 2 compatibility for FabricLoader subclasses e.g. lunar client#28

Merged
Johni0702 merged 2 commits intomasterfrom
FabricLoader-getInstance-subclass-compatibility
Feb 23, 2026
Merged

add stage 2 compatibility for FabricLoader subclasses e.g. lunar client#28
Johni0702 merged 2 commits intomasterfrom
FabricLoader-getInstance-subclass-compatibility

Conversation

@Traben-0
Copy link
Contributor

@Traben-0 Traben-0 commented Nov 9, 2025

I am unable to test via local maven due to build failures on windows due to it generating directories with ":"

If there is some other testing method @Johni0702 i'd like to learn it / give it a go before we merge, also just to make sure there isnt anything else affecting this linear issue that the reporter may have missed.

Linear: EM-3472

@Traben-0 Traben-0 requested a review from Johni0702 November 9, 2025 11:39
@github-actions
Copy link

github-actions bot commented Nov 9, 2025

Test Results

16 files  ±0  16 suites  ±0   11m 41s ⏱️ -4s
95 tests ±0  95 ✅ ±0  0 💤 ±0  0 ❌ ±0 
99 runs  ±0  99 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 4e584e7. ± Comparison against base commit d75286a.

♻️ This comment has been updated with latest results.

@Traben-0 Traben-0 requested a review from Johni0702 January 7, 2026 06:37
@Traben-0
Copy link
Contributor Author

Traben-0 commented Jan 8, 2026

confirmed to have fixed this lunar client load exception
image

note essential still doesn't appear in the mod menu on lunar client, but it is loaded and accessibla via the vanilla settings screen

@Johni0702 Johni0702 merged commit a56b26f into master Feb 23, 2026
36 checks passed
@Johni0702 Johni0702 deleted the FabricLoader-getInstance-subclass-compatibility branch February 23, 2026 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants