GH-1316 Simple fix of back command not registering teleports#1316
Open
GH-1316 Simple fix of back command not registering teleports#1316
Conversation
CitralFlo
changed the title
CitralFlo
requested review from
ChudziudgiToJa,
Jakubk15,
Rollczi,
igoyek,
imDMK and
vLuckyyy
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request aims to fix an issue where plugin-based teleports were not being registered for the /back command. However, the change introduces a logic error in the teleport recording mechanism, inverting the filter for teleport causes. This results in the plugin only recording teleports initiated by other plugins, ignoring standard player-initiated teleports (e.g., portals, vanilla commands). This not only breaks intended functionality but also creates a potential security bypass, allowing players to return to restricted areas they were moved from by staff or automated systems.
eternalcore-core/src/main/java/com/eternalcode/core/feature/back/BackController.java
Outdated
Show resolved
Hide resolved
imDMK
approved these changes
Mar 3, 2026
vLuckyyy
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.