This repository was archived by the owner on Jan 17, 2020. It is now read-only.
Use latest revision's title in all review actions#96
Open
lehmannro wants to merge 3 commits intoEuroPython:developfrom
Open
Use latest revision's title in all review actions#96lehmannro wants to merge 3 commits intoEuroPython:developfrom
lehmannro wants to merge 3 commits intoEuroPython:developfrom
Conversation
Contributor
|
Nice idea to clean up the templates. However, I'd move the decision weather there is a proposal version or not, as a property to the Have a look at the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This hotfixes #95 and should replace all improper uses of the proposal's title with the latest proposal version's title.
A cleaner approach would be supplying a non-null template variable which points to the latest proposal, whether there were revisions or not, and just referring to that proposal's title. This would also clean up the whole
{% if proposal_version %}{{ proposal_version.yadda }}{% else %}{{ proposal.yadda }}{% endif %}business all over the templates.These commits go untested.