Open
Conversation
Contributor
jenny-s51
commented
Nov 7, 2018
jenny-s51
commented
- UI fix for password complexity popup
- complexity standards are now stated in alert message
Contributor
Author
|
saurabh21289
approved these changes
Nov 9, 2018
Contributor
Author
|
jenny-s51
changed the title
shreyapandit
requested changes
Nov 27, 2018
Collaborator
shreyapandit
left a comment
shreyapandit
left a comment
There was a problem hiding this comment.
Hi Jenny, this looks good overall. Could you also add the fix to the create user page where it falsely states that passwords don't match and allows you to go through?
Contributor
Author
|
Contributor
Author
|
password complexity requirements now stated on top of "create user" and "sign up" pgs. |
Collaborator
|
Hi @jenny-s51 , thaks for your work on this. |
…serasroot * origin/jenny_UI-fixes: password standards now static on top of "sign up" and "create user" pgs. password complexity requirements now stated @ top of "create user" pg.
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.