TASK: TaskCollectionFactory ignores non existing configured handlerCass#11
Open
gjwnc wants to merge 1 commit intoFlowpack:mainfrom
Open
TASK: TaskCollectionFactory ignores non existing configured handlerCass#11gjwnc wants to merge 1 commit intoFlowpack:mainfrom
gjwnc wants to merge 1 commit intoFlowpack:mainfrom
Conversation
…ass and writes message to log
Contributor
Author
|
@daniellienert The case, that a task implementation is removed, still needs to be addressed. I could try to add some kind of auto cleanup, e.g. if a task is registered in the database but I would add this in another PR - see (#13) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just had the case, that an invalid handleClass was written into the DB and had to remove it manually from there. With this PR, a configured tasks is checked with
class_existsand if it doesn't exist, the this task is ignored and an info message is written to the system log.