Skip to content

补全缺失 Header#5687

Open
CiiLu wants to merge 2 commits intoHMCL-dev:mainfrom
CiiLu:headler
Open

补全缺失 Header#5687
CiiLu wants to merge 2 commits intoHMCL-dev:mainfrom
CiiLu:headler

Conversation

@CiiLu
Copy link
Contributor

@CiiLu CiiLu commented Mar 2, 2026

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fills in missing GPLv3 license header blocks across several Java source and test files in the HMCL project (including buildSrc, HMCLCore, and HMCL), bringing them in line with the repository’s standard file header practices.

Changes:

  • Add the standard “Hello Minecraft! Launcher” GPLv3 header to Java source files that previously lacked it.
  • Add the same header to multiple JUnit test classes that previously lacked it.
  • Apply the header consistently across Gradle buildSrc tasks and core/UI modules.

Reviewed changes

Copilot reviewed 38 out of 38 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
buildSrc/src/main/java/org/jackhuang/hmcl/gradle/TerracottaConfigUpgradeTask.java Add missing GPL header
HMCLCore/src/test/java/org/jackhuang/hmcl/util/versioning/VersionRangeTest.java Add missing GPL header
HMCLCore/src/test/java/org/jackhuang/hmcl/util/skin/NormalizedSkinTest.java Add missing GPL header
HMCLCore/src/test/java/org/jackhuang/hmcl/util/platform/JavaRuntimeTest.java Add missing GPL header
HMCLCore/src/test/java/org/jackhuang/hmcl/util/io/CompressingUtilsTest.java Add missing GPL header
HMCLCore/src/test/java/org/jackhuang/hmcl/util/gson/InstantTypeAdapterTest.java Add missing GPL header
HMCLCore/src/test/java/org/jackhuang/hmcl/util/TokenizerTest.java Add missing GPL header
HMCLCore/src/test/java/org/jackhuang/hmcl/util/KeyValuePairUtilsTest.java Add missing GPL header
HMCLCore/src/test/java/org/jackhuang/hmcl/util/CircularArrayListTest.java Add missing GPL header
HMCLCore/src/main/java/org/jackhuang/hmcl/util/versioning/VersionRange.java Add missing GPL header
HMCLCore/src/main/java/org/jackhuang/hmcl/util/io/DirectoryStructurePrinter.java Add missing GPL header
HMCLCore/src/main/java/org/jackhuang/hmcl/util/gson/JsonTypeAdapterFactory.java Add missing GPL header
HMCLCore/src/main/java/org/jackhuang/hmcl/util/gson/JsonType.java Add missing GPL header
HMCLCore/src/main/java/org/jackhuang/hmcl/util/gson/JsonSubtype.java Add missing GPL header
HMCLCore/src/main/java/org/jackhuang/hmcl/util/Holder.java Add missing GPL header
HMCLCore/src/main/java/org/jackhuang/hmcl/util/CircularArrayList.java Add missing GPL header
HMCLCore/src/main/java/org/jackhuang/hmcl/task/TaskCompletableFuture.java Add missing GPL header
HMCLCore/src/main/java/org/jackhuang/hmcl/resourcepack/ResourcepackZipFile.java Add missing GPL header
HMCLCore/src/main/java/org/jackhuang/hmcl/resourcepack/ResourcepackFolder.java Add missing GPL header
HMCLCore/src/main/java/org/jackhuang/hmcl/resourcepack/ResourcepackFile.java Add missing GPL header
HMCLCore/src/main/java/org/jackhuang/hmcl/mod/multimc/MultiMCComponents.java Add missing GPL header
HMCLCore/src/main/java/org/jackhuang/hmcl/mod/modrinth/ModrinthModpackExportTask.java Add missing GPL header
HMCLCore/src/main/java/org/jackhuang/hmcl/mod/modinfo/QuiltModMetadata.java Add missing GPL header
HMCLCore/src/main/java/org/jackhuang/hmcl/mod/modinfo/ForgeNewModMetadata.java Add missing GPL header
HMCLCore/src/main/java/org/jackhuang/hmcl/mod/ModpackExportInfo.java Add missing GPL header
HMCLCore/src/main/java/org/jackhuang/hmcl/launch/ExecutionPolicyLimitException.java Add missing GPL header
HMCLCore/src/main/java/org/jackhuang/hmcl/launch/CommandTooLongException.java Add missing GPL header
HMCLCore/src/main/java/org/jackhuang/hmcl/game/Renderer.java Add missing GPL header
HMCLCore/src/main/java/org/jackhuang/hmcl/game/NativesDirectoryType.java Add missing GPL header
HMCLCore/src/main/java/org/jackhuang/hmcl/download/neoforge/NeoForgeRemoteVersion.java Add missing GPL header
HMCLCore/src/main/java/org/jackhuang/hmcl/download/neoforge/NeoForgeOfficialVersionList.java Add missing GPL header
HMCLCore/src/main/java/org/jackhuang/hmcl/download/neoforge/NeoForgeInstallTask.java Add missing GPL header
HMCL/src/test/java/org/jackhuang/hmcl/util/AggregatedObservableListTest.java Add missing GPL header
HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/ResourcepackListPage.java Add missing GPL header
HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/AdvancedVersionSettingPage.java Add missing GPL header
HMCL/src/main/java/org/jackhuang/hmcl/ui/download/ModpackPage.java Add missing GPL header
HMCL/src/main/java/org/jackhuang/hmcl/setting/SambaException.java Add missing GPL header
HMCL/src/main/java/org/jackhuang/hmcl/countly/CrashReport.java Add missing GPL header

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

* You should have received a copy of the GNU General Public License
* along with this program. If not, see <https://www.gnu.org/licenses/>.
*/

Copy link

Copilot AI Mar 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an empty line between the GPL header and the package declaration. To match the predominant header style in the codebase (where package follows immediately after */), consider removing this extra blank line (and keeping the formatting consistent across the other files updated in this PR).

Suggested change

Copilot uses AI. Check for mistakes.
Comment on lines +16 to 20
* along with this program. If not, see <https://www.gnu.org/licenses/>.
*/

package org.jackhuang.hmcl.ui.versions;

Copy link

Copilot AI Mar 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file header formatting here adds an extra blank line between the GPL comment block and the package declaration. Most existing Java files in this repo place package ...; immediately after the */ (no empty line), so it would be more consistent to remove this blank line (and apply the same formatting to the other headers added in this PR).

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants