Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
该 PR 修复了游戏版本号在遇到 -pre-（例如 26.1-pre-1）这种格式时无法正确归一化的问题，确保 toNormalizedString() 能输出项目期望的标准形式（-pre1）。
Changes:
- 在
GameVersionNumber.Release.parse中新增对-pre-前缀的解析与归一化逻辑 - 增加单元测试覆盖
26.1-pre-1->26.1-pre1的归一化结果
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| HMCLCore/src/main/java/org/jackhuang/hmcl/util/versioning/GameVersionNumber.java | 在解析后缀时识别 -pre- 并设置 needNormalize，归一化为 -pre + 版本号 |
| HMCLCore/src/test/java/org/jackhuang/hmcl/util/versioning/GameVersionNumberTest.java | 新增用例验证 26.1-pre-1 会被归一化为 26.1-pre1 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Glavo
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.