feat: add optional datasetType to DatasetDTO and include in transform…#354
Draft
feat: add optional datasetType to DatasetDTO and include in transform…#354
Conversation
pdurbin
added a commit
to pdurbin/dataverse-frontend
that referenced
this pull request
Sep 8, 2025
Note that it depends on this PR: IQSS/dataverse-client-javascript#354 However, there's a new PR to try instead: IQSS/dataverse-client-javascript#360
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for handling the
datasetTypeproperty in the dataset DTO and ensures it is correctly included in payload transformations. The main changes are grouped by DTO updates and transformer logic enhancements.DTO updates:
datasetTypeproperty to theDatasetDTOinterface insrc/datasets/domain/dtos/DatasetDTO.ts, allowing datasets to specify their type.Transformer logic enhancements:
transformDatasetModelToNewDatasetRequestPayloadfunction insrc/datasets/infra/repositories/transformers/datasetTransformers.tsto conditionally includedatasetTypein the payload if it is present in the dataset.