Skip to content

Move _tensor_impl extensions and use it for dpnp#2755

Merged
vlad-perevezentsev merged 23 commits intoinclude-dpctl-tensorfrom
move_tensor_impl_ext
Feb 19, 2026
Merged

Move _tensor_impl extensions and use it for dpnp#2755
vlad-perevezentsev merged 23 commits intoinclude-dpctl-tensorfrom
move_tensor_impl_ext

Conversation

@vlad-perevezentsev
Copy link
Contributor

@vlad-perevezentsev vlad-perevezentsev commented Feb 5, 2026

This PR proposes introducing dpctl_ext as a new internal extension module (temporarily renamed from dpctl to avoid conflicts), adding CMake/packaging support for building _tensor_impl via pybind11 and switching dpnp to use dpctl_ext.tensor. _tensor_impl

The migrated _tensor_impl currently supports the following functions:

'_array_overlap',
'_as_c_contig',
'_as_f_contig',
'_contract_iter',
'_contract_iter2',
'_contract_iter3',
'_contract_iter4',
'_copy_usm_ndarray_into_usm_ndarray',
'_ravel_multi_index',
'_same_logical_tensors',
'_unravel_index',
'default_device_bool_type',
'default_device_complex_type',
'default_device_fp_type',
'default_device_index_type',
'default_device_int_type',
'default_device_uint_type'

Files in dpnp that explicitly import dpctl.tensor._tensor_impl
Green items are handled in this PR
Red items will be handled in the next PR (#2758 )
123

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@vlad-perevezentsev vlad-perevezentsev self-assigned this Feb 5, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

Array API standard conformance tests for dpnp=0.20.0dev3=py313h509198e_30 ran successfully.
Passed: 1353
Failed: 4
Skipped: 7

Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please find the comments above

Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antonwolfy already covered most thoughts I would have and more, I think this looks good

@vlad-perevezentsev vlad-perevezentsev merged commit 1a1a099 into include-dpctl-tensor Feb 19, 2026
85 of 92 checks passed
@vlad-perevezentsev vlad-perevezentsev deleted the move_tensor_impl_ext branch February 19, 2026 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments