[MAINT] Add pre commit hooks#94
Open
ndgrigorian wants to merge 8 commits intofeature/add-numpy-random-interfacefrom
Open
[MAINT] Add pre commit hooks#94ndgrigorian wants to merge 8 commits intofeature/add-numpy-random-interfacefrom
ndgrigorian wants to merge 8 commits intofeature/add-numpy-random-interfacefrom
Conversation
ndgrigorian
requested review from
antonwolfy,
jharlow-intel and
xaleryb
as code owners
ndgrigorian
changed the base branch from
master
to
feature/add-numpy-random-interface
ndgrigorian
force-pushed
the
add-pre-commit-hooks
branch
2 times, most recently
from
321ba3b to
f9cfa6e
Compare
Collaborator
Author
|
these changes have (by some twisted miracle) introduced build failures—but only on Windows. I will have to undo and find the root cause of this. |
ndgrigorian
force-pushed
the
add-pre-commit-hooks
branch
from
f9fdc04 to
dbdcae3
Compare
ndgrigorian
force-pushed
the
add-pre-commit-hooks
branch
from
dbdcae3 to
4ca26c7
Compare
ndgrigorian
force-pushed
the
add-pre-commit-hooks
branch
from
4ca26c7 to
bf54ddc
Compare
Collaborator
Author
seems clang-format caused it, likely order of includes. I will exclude include blocks from clang-formatting |
ndgrigorian
force-pushed
the
add-pre-commit-hooks
branch
3 times, most recently
from
715bb4f to
e5b5825
Compare
ndgrigorian
force-pushed
the
add-pre-commit-hooks
branch
3 times, most recently
from
ce639f1 to
ec87861
Compare
ndgrigorian
force-pushed
the
feature/add-numpy-random-interface
branch
from
e612350 to
5ffbb5a
Compare
ndgrigorian
force-pushed
the
add-pre-commit-hooks
branch
from
ec87861 to
47953a2
Compare
antonwolfy
reviewed
Feb 27, 2026
Collaborator
Author
|
@antonwolfy |
antonwolfy
reviewed
Mar 1, 2026
| steps: | ||
| - name: Checkout repo | ||
| uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
|
|
Collaborator
There was a problem hiding this comment.
Do we need that? (used in dpnp)
Suggested change
| with: | |
| # use commit hash to make "no-commit-to-branch" check passing | |
| ref: ${{ github.sha }} | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds pre-commit hooks to the project, following similar work last year in
mkl_fftAlso updates to conform with new linters (including cython-lint), adds a pre-commit check workflow, and adds changes to
.git-blame-ignore-revsCloses #61