Open
Conversation
Member
|
Hi ! Sorry for not looking at this issue earlier, your contribution is very much appreciated 🙏 |
Pyrofab
reviewed
Mar 10, 2026
Comment on lines
+17
to
+20
| @ModifyExpressionValue(method = "set", at = @At(value = "INVOKE", target = "Lnet/minecraft/scoreboard/ScoreboardState$Packed;equals(Ljava/lang/Object;)Z")) | ||
| private boolean compareComponentValues(boolean original, ScoreboardState.Packed packed){ | ||
| return original && Objects.equals(((CcaPackedState) (Object) packed).cca$getSerializedComponents(), ((CcaPackedState) (Object) packedState).cca$getSerializedComponents()); | ||
| } |
Member
There was a problem hiding this comment.
I think it's better to directly inject into Packed#equals actually, I'll push the change if you don't object
Pyrofab
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the bug in which scoreboard components would never be written due to their component data not being checked when determining whether to write the scoreboard.
This bug was reported as issue #222
I've also added a subcommand to the testmod that could make preventing similair bugs easier.