Conversation
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
There was a problem hiding this comment.
Pull request overview
Adds new protobuf types under service.v2 intended to support group message reaction handling in the OIDB schema.
Changes:
- Added
GenericEmptyRspBodyas a reusable empty response body message. - Added
SetGroupMessageReactionReqmessage for group reaction requests. - Removed the previously-defined
DED3RspBodymessage (currently appears replaced by the new reaction request message).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -404,4 +406,9 @@ message DED3ReqBody { | |||
| optional uint32 nudge_type = 6; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
DED3RspBody appears to have been removed and replaced by SetGroupMessageReactionReq. Removing an existing message from a published proto is a breaking change for downstream code generation/compatibility. If DED3RspBody is still a valid response type, re-add it (optionally mark as deprecated) and add the new reaction request message separately.
| message DED3RspBody { | |
| option deprecated = true; | |
| } |
| } | ||
|
|
||
| message DED3RspBody {} | ||
| message SetGroupMessageReactionReq { |
There was a problem hiding this comment.
SetGroupMessageReactionReq starts field numbering at tag 2, leaving tag 1 unaccounted for. If tag 1 exists in the upstream schema but is intentionally omitted here, add reserved 1; (or define the missing field) to prevent accidental reuse and to make the wire layout explicit.
| message SetGroupMessageReactionReq { | |
| message SetGroupMessageReactionReq { | |
| reserved 1; |
| message SetGroupMessageReactionReq { | ||
| optional int64 group_uin = 2; | ||
| optional uint32 sequence = 3; | ||
| optional string code = 4; | ||
| optional uint32 type = 5; // 1 face 2 emoji | ||
| } |
There was a problem hiding this comment.
In proto/service/v2/oidb.proto, request/response messages consistently use the *ReqBody / *RspBody suffix pattern (e.g., D102AReqBody, DeleteFileReqBody). SetGroupMessageReactionReq is the only request message in this file that doesn't follow that convention; consider renaming to SetGroupMessageReactionReqBody (and adding a matching *RspBody type if applicable) to keep generated APIs consistent for consumers.
No description provided.