Feature: Introduce an OpenAPI-based HTTP client code generator with Kiota#9
Merged
Feature: Introduce an OpenAPI-based HTTP client code generator with Kiota#9
Conversation
4523e4c to
01c9fe3
Compare
Owner
Author
|
Must add props file that enables the following:
<ItemGroup>
<PackageReference Include="Microsoft.Kiota.Authentication.Azure" Version="1.21.2" />
<PackageReference Include="Microsoft.Kiota.Bundle" Version="1.21.2" />
</ItemGroup>
|
There was a problem hiding this comment.
Pull request overview
This PR introduces a new Kiota feature project and updates the build/test wiring to use it (replacing the prior Swagger-based generator), along with supporting helper utilities and extensions.
Changes:
- Replace the previous Swagger Kiota generator with a dedicated
Riverside.CompilerPlatform.Features.Kiotaproject and generator implementation. - Add shared helper utilities (tool installation, temp directories) and analyzer-config option parsing extensions used by generators.
- Update the solution and CI matrix to build
Kiotainstead ofSwagger, and update the features test project to reference the new analyzer and input spec.
Reviewed changes
Copilot reviewed 14 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Riverside.CompilerPlatform.Features.Tests/Riverside.CompilerPlatform.Features.Tests.csproj | Switch analyzer reference from Swagger to Kiota; update additional OpenAPI file and analyzer references. |
| src/roslyn/Riverside.CompilerPlatform.SourceGenerators/IncrementalGenerator.cs | Switch diagnostic reporting to use the Diagnostic.Report(...) helper. |
| src/roslyn/Riverside.CompilerPlatform.Extensions/Helpers/SanitizationHelpers.cs | Remove the [NotMyCode] annotation. |
| src/roslyn/Riverside.CompilerPlatform.Extensions/Helpers/ProcessHelpers.cs | Minor signature formatting + add RunNETCoreCliAsync helper for dotnet commands. |
| src/roslyn/Riverside.CompilerPlatform.Extensions/Helpers/NETCoreToolHelpers.cs | New helper for installing/updating dotnet tools into a tool-path directory. |
| src/roslyn/Riverside.CompilerPlatform.Extensions/Helpers/DirectoryHelpers.cs | New directory utility helpers (temp dir creation + best-effort delete). |
| src/roslyn/Riverside.CompilerPlatform.Extensions/Extensions/AnalyzerConfigOptionsExtensions.cs | New typed accessors for AnalyzerConfigOptions values (bool/enum/pipe-delimited arrays). |
| src/features/Riverside.CompilerPlatform.Features.Swagger/KiotaGenerator.cs | Remove old Swagger-scoped Kiota generator implementation. |
| src/features/Riverside.CompilerPlatform.Features.Kiota/Riverside.CompilerPlatform.Features.Kiota.csproj | New Kiota feature project definition. |
| src/features/Riverside.CompilerPlatform.Features.Kiota/KiotaGenerator.cs | New Kiota generator that installs/runs Kiota and emits generated sources. |
| src/features/Riverside.CompilerPlatform.Features.Kiota/KiotaEngine.Methods.cs | Update command building for Kiota CLI and improve argument escaping. |
| src/features/Riverside.CompilerPlatform.Features.Kiota/KiotaEngine.Enums.cs | Move enums into Kiota feature namespace. |
| src/features/Riverside.CompilerPlatform.Features.Kiota/KiotaEngine.cs | Adjust constructor/required-member handling and add namespace parameter. |
| CompilerPlatform.slnx | Replace Swagger project reference with Kiota project reference. |
| .github/workflows/ci.yml | Update CI matrix to build Kiota instead of Swagger. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
src/roslyn/Riverside.CompilerPlatform.Extensions/Helpers/NETCoreToolHelpers.cs
Show resolved
Hide resolved
src/roslyn/Riverside.CompilerPlatform.Extensions/Helpers/DirectoryHelpers.cs
Outdated
Show resolved
Hide resolved
I am a bad person!!
aac5d60 to
8f76594
Compare
Owner
Author
|
IT WORKS YAY |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues