Skip to content

Conversation

@ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Feb 11, 2026

Description

Migrate to new prebuilt structure for build-deps.

The build-deps repo is still a submodule, but now points to the master branch. Cmake will download the correct asset, based on the commit/tag of the submodule.

We will have to manually update the ffmpeg module for flatpak though as dependabot will not handle this. I will try to implement https://github.com/flathub-infra/flatpak-external-data-checker separately.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@ReenigneArcher ReenigneArcher force-pushed the build/deps/migrate-ffmpeg-prebuild-to-downloaded-archive branch 2 times, most recently from 7599b0a to 4a70ac7 Compare February 11, 2026 00:10
@ReenigneArcher ReenigneArcher force-pushed the build/deps/migrate-ffmpeg-prebuild-to-downloaded-archive branch from 4a70ac7 to 213198a Compare February 11, 2026 00:13
@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Feb 11, 2026

Bundle Report

Changes will decrease total bundle size by 39 bytes (-0.01%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sunshine-esm 771.51kB -39 bytes (-0.01%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sunshine-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/config-*.js -39 bytes 67.18kB -0.06%

@codecov
Copy link

codecov bot commented Feb 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 15.53%. Comparing base (4b1bc6a) to head (213198a).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4699      +/-   ##
==========================================
+ Coverage   15.51%   15.53%   +0.01%     
==========================================
  Files          97       97              
  Lines       20469    20469              
  Branches     9398     9398              
==========================================
+ Hits         3176     3179       +3     
+ Misses      13409    12743     -666     
- Partials     3884     4547     +663     
Flag Coverage Δ
Archlinux 11.20% <ø> (ø)
FreeBSD-14.3-aarch64 ?
FreeBSD-14.3-amd64 13.23% <ø> (-0.01%) ⬇️
Homebrew-ubuntu-22.04 13.43% <ø> (ø)
Linux-AppImage 11.61% <ø> (ø)
Windows-AMD64 13.49% <ø> (ø)
Windows-ARM64 12.35% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 29 files with indirect coverage changes

@ReenigneArcher ReenigneArcher merged commit 9d06228 into master Feb 11, 2026
88 of 93 checks passed
@ReenigneArcher ReenigneArcher deleted the build/deps/migrate-ffmpeg-prebuild-to-downloaded-archive branch February 11, 2026 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant