Don't run step if miniprofiler doesn't exist#8
Open
oleg-polivannyi wants to merge 1 commit intoMiniProfiler:masterfrom
Open
Don't run step if miniprofiler doesn't exist#8oleg-polivannyi wants to merge 1 commit intoMiniProfiler:masterfrom
oleg-polivannyi wants to merge 1 commit intoMiniProfiler:masterfrom
Conversation
Contributor
|
We tracked this bug and found that when using body-parser it mutates the This PR is a patch that don't affect most of timings, as conflict with body-parser only happens on request that uses The proper solution for this problem is to refactor minprofiler internals to not depend on So this patch PR LGTM 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason, miniprofiler object isn't accessible in middleware in some conditions