Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts LDAP ModifyDN authorization and related ORM loading so ModifyDN operations can correctly evaluate access control entries (ACEs) for rename and move scenarios.
Changes:
- Refactors
AccessManager.mutate_query_with_ace_loadto build loader options more flexibly and eager-load additional ACE relations. - Updates ModifyDN handling to differentiate rename vs move-to-new-superior, adding explicit rename and delete checks and refactoring ACE membership update logic into helpers.
- Adds eager-loading of
Directory.entity_typein the Delete request query.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| app/ldap_protocol/roles/access_manager.py | Refactors ACE loader option construction and changes what related ACE data is always eager-loaded. |
| app/ldap_protocol/ldap_requests/modify_dn.py | Adds/changes ModifyDN access checks (rename vs move) and refactors ACE cleanup/update logic into helper methods. |
| app/ldap_protocol/ldap_requests/delete.py | Adds eager loading of Directory.entity_type in delete query options. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ead of directory_id
rimu-stack
requested changes
Feb 11, 2026
Comment on lines
109
to
117
| changes=[ | ||
| Changes( | ||
| operation=Operation.REPLACE, | ||
| modification=PartialAttribute(type="name", vals=[name]), | ||
| ), | ||
| ], | ||
| aces=directory.access_control_entries, | ||
| entity_type_id=directory.entity_type_id, | ||
| ) |
Collaborator
There was a problem hiding this comment.
заменить проверку на directory.rdn
должны быть 2 разные проверки
- replace old_rdn
- delete old_rdn + add new_rdn
Collaborator
Author
rimu-stack
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Задача: 1256
Изменения:
ACEдобавлена подгрузка EntityType, его авто-подгрузку в какой-то момент убрали и забыли добавить вручную.