Refactor status to be a type #137
Conversation
| type Status int | ||
|
|
||
| const ( | ||
| Invalid Status = iota - 1 |
There was a problem hiding this comment.
Not sure about this one. I kinda wanted something to "mean" error/invalid and we use a -1 value in result.WorstState.
There was a problem hiding this comment.
That is one problem of the whole monitoring plugins interface, there is no "error" state
There was a problem hiding this comment.
Any ideas? just use Unknown and add some custom error types?
There was a problem hiding this comment.
hm, we could keep an "error" code and map it to "UNKNOWN" at exit, that would be nice from a programer perspective, but also confusing since the end is the same.
RincewindsHat
left a comment
RincewindsHat
left a comment
There was a problem hiding this comment.
Not ideal, but there is only so much one can do under the given circumstances.
In general I think this is an improvement and we should go with it.
2 participants
For the v1 Release we want to introduce a proper State Type for the v1.0.0 - that type can then just implement the Stringer interface and have a NewFromInt/String function.
Fixes #125
This also changes check.ExitRaw to Exit and removes the Exitf.