Open
Conversation
Signed-off-by: romintomasetti <[email protected]>
Collaborator
|
i have been wanting to make some changes to stdexec formatting to improve readability. i can do that now, then we can use this CI job to keep things tidy. |
Collaborator
|
/ok to test 87db570 |
Collaborator
looks like the job will need to apt install git first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When working on a feature or fix, it's easy to inadvertently touch unrelated lines due to pre-existing formatting inconsistencies. This adds noise to diffs and makes it harder to understand what a commit is actually doing.
This PR introduces a
style.ymlCI job as a dedicated place for style-related checks, starting withclang-format. Having this enforced in CI keeps formatting concerns out of feature PRs going forward.Note that I expect the job to fail for now because there are quite a few pre-existing formatting issues in the codebase.
@ericniebler Would you be open to landing a formatting cleanup commit first so we can get this green from the start?
@ericneibler I've also deleted
.github/workflows/test-clang-format.shbecause I don't think it's used. But there seems to be other scripts in there that can be deleted.