Open
Conversation
4 tasks
Member
|
/ocabot migration base_import_async |
hoangtrann
approved these changes
Jan 5, 2026
Contributor
hoangtrann
left a comment
There was a problem hiding this comment.
Code LGTM, though you can now remove queue_job from test-requirements.txt
f42ea1a to
e83c07f
Compare
- Move BaseImportImport wizard code to wizard/\n- Update tests and async import flow\n- Update pre-commit exclusions
4416fe3 to
eba1ed2
Compare
Author
|
Hi @hoangtrann @sbidoul , I rebased the branch on 19.0, resolved the conflicts, and addressed the review nits (removed the obsolete test-requirements.txt dependency and the “Odoo 19” comment). I also restored requirements.txt (generated from external_dependencies) and added tests to improve coverage. Finally, I squashed the PR into a single commit; CI is running again on the new head. Please double check if this is ready to get merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope:
Depends on:
Summary:
Temporary references:
Pre-commit:
Tests: