Fix ValueError for unsupported LLM architectures in InternVLChatConfig#1255
Open
Mr-Neutr0n wants to merge 1 commit intoOpenGVLab:mainfrom
Open
Fix ValueError for unsupported LLM architectures in InternVLChatConfig#1255Mr-Neutr0n wants to merge 1 commit intoOpenGVLab:mainfrom
Mr-Neutr0n wants to merge 1 commit intoOpenGVLab:mainfrom
Conversation
Use AutoConfig.for_model as a fallback for architectures not explicitly listed (e.g. Qwen3ForCausalLM), instead of raising a ValueError. Also fix the empty-string architecture default when llm_config is None, which caused a misleading error on transformers >= 4.44.
Author
|
Friendly bump! Let me know if there's anything I should update or improve to help move this forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AutoConfig.for_modelas a fallback when the LLM architecture is not explicitly listed inInternVLChatConfig, instead of raising aValueErrorQwen3ForCausalLMwithout requiring code changes for each new architecturellm_configwhenNoneis passed: previously set{'architectures': ['']}which produced a misleadingValueError: Unsupported architecture:with an empty stringFixes #1203
Test plan
llm_config=Nonefalls back to LlamaConfig without raising